elek commented on pull request #1093: URL: https://github.com/apache/hadoop-ozone/pull/1093#issuecomment-647475183
> Pass SECURITY_ENABLED and similar variables as Robot variables (-v), not environment ones (-e). This allows setting default value in Robot tests, which makes it easier to run the test from command-line. DANCING BANANA. Thank you very much, The patch LGTM. One comment: `string_test.robot` and `fs_test.robot` seems to be duplicate of `robot.robot`. (I guess you refactored the `robot.robot` to two separated files.) I think one of them can be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
