elek commented on a change in pull request #1125:
URL: https://github.com/apache/hadoop-ozone/pull/1125#discussion_r445482901
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/S3KeyGenerator.java
##########
@@ -54,7 +64,8 @@
private String bucketName;
@Option(names = {"-s", "--size"},
- description = "Size of the generated key (in bytes)",
+ description = "Size of the generated key (in bytes) or size of one "
+ + "multipart upload part (in case of multipart upload)",
Review comment:
The backend will fail anyway thanks to the implementation there...
(guess, you were more thoroughgoing ;-) )
But yes, it's slightly more polite to fail early (and creates less garbage).
Added a simple check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
