cxorm commented on a change in pull request #958:
URL: https://github.com/apache/hadoop-ozone/pull/958#discussion_r445504458
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyDeleteResponse.java
##########
@@ -86,6 +86,9 @@ public void addToDBBatch(OMMetadataManager omMetadataManager,
isRatisEnabled);
omMetadataManager.getDeletedTable().putWithBatch(batchOperation,
ozoneKey, repeatedOmKeyInfo);
+ // Update trashTable in DB.
+ omMetadataManager.getTrashTable().putWithBatch(batchOperation,
Review comment:
> Ideally, if a key gets deleted from a bucket which is trash enabled, i
think we should just add it to the trash table, not the deleted table,
otherwise it will lead to having duplicate entries in both trash and delete
table. Once the trash interval expires, keys can be moved from trash table to
deleted table using a background task which will then be cleaned by the
KeyDeleting Service. What do you think?
Yeah, I agree that we shouldn't have duplicated entries in both and delete
table.
This part would be updated .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
