elek commented on a change in pull request #1123: URL: https://github.com/apache/hadoop-ozone/pull/1123#discussion_r445997165
########## File path: hadoop-ozone/dist/src/main/k8s/examples/regenerate-all.sh ########## @@ -0,0 +1,29 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +set -e + +if [ ! -x "$(command -v flekszible)" ]; then + echo "flekszible tool is required for regenerating Kubernetes files" + exit 1 +fi + +SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd ) +cd "$SCRIPT_DIR" +for dir in $(find . -maxdepth 1 -mindepth 1 -type d -printf '%f\n'); do Review comment: Thanks the review @maobaolong > On macosx, the find command is minor different with Linux, so is there another tool can replace find? Yes, I started with a simple `ls`, but shellcheck complained that it couldn't work with space in the dir names (which not supposed to be used). Fixed back. > It cannot work without flekszible.yaml fiie It's a bug in a recent addition in flekszible. Can you please use [1.8.0 version](https://github.com/elek/flekszible/releases/tag/v1.8.0) which contains the fix. (OSX test is added to Flekszible to avoid similar issues in the future) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
