elek commented on pull request #1057: URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-650144219
I got it, and I convinced by you to remove the affinity rules from `ozone-dev` and `getting-started` and we agreed to keep it in `ozone` (as it supposed to be a production-like example). My problem is that the files under `example` are **generated** to simplify the management. For example, we can add any new labels to the master template and regenerate all the examples.(with #1123). I am convinced to remove the affinity rules *by default*, but if you do it **only** in the generated files, they will be overridden with the next generation. (To make all the files independent of the generation, I prefer to commit the end results, what you can see in the examples which makes the existence of the generation tool optional). I tried to propose to modify BOTH the generated files AND the rules for the generation, to persist the change. It was not about following a different default. (Sorry if it was not clear or misunderstood your comment) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
