runzhiwang commented on a change in pull request #1053:
URL: https://github.com/apache/hadoop-ozone/pull/1053#discussion_r447544624



##########
File path: 
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
##########
@@ -301,14 +306,21 @@ public static Pipeline 
getFromProtobuf(HddsProtos.Pipeline pipeline)
     for (DatanodeDetailsProto member : pipeline.getMembersList()) {
       nodes.add(DatanodeDetails.getFromProtoBuf(member));
     }
+    UUID leaderId = null;
+    if (pipeline.hasLeaderID() &&
+        StringUtils.isNotEmpty(pipeline.getLeaderID())) {
+      leaderId = UUID.fromString(pipeline.getLeaderID());

Review comment:
       @xiaoyuyao  Sorry for missing the comment. @elek  Thanks for reminding.
   
   > The improvement will be limited as fromProtoBuf to String will prefer 
process UUID before ID128
   
   Do you mean we should prefer ID128 before process UUID.fromString ? If so, I 
think you are totally right, I will update it.  Besides I will also remove  
UUID.fromString in the future.
   
   > And to protoBuf will need to add both String version of UUID and the 
long/long version of uuid 128
   
   This is for compatibility, in the future, I will remove String version of 
UUID.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to