smengcl commented on pull request #1088: URL: https://github.com/apache/hadoop-ozone/pull/1088#issuecomment-652248876
@elek I've added a few commits since you last reviewed. I have removed OFS classes' dependency on `OzoneClientAdapter`, and added new methods in the `Impl` so it doesn't leak proxy (`ClientProtocol`) to `BasicRootedOzoneFileSystem` anymore. I am considering merging `BasicRootedOzoneFileSystem` and `BasicRootedOzoneFileSystemImpl` (was `BasicRootedOzoneClientAdapterImpl`) but each are 850+ lines long so I might do this in another jira. Now that all the existing tests have passed. Mind taking another look at this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
