xiaoyuyao commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454011179
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##########
@@ -77,6 +80,122 @@ public Text getKind() {
return KIND_NAME;
}
+ /** Instead of relying on proto serialization, this
+ * provides explicit serialization for OzoneTokenIdentifier.
+ * @return byte[]
+ */
+ public byte[] toUniqueSerializedKey() {
+ ByteBuffer result =
+ ByteBuffer.allocate(4096);
+ result.order(ByteOrder.BIG_ENDIAN);
+ try {
+ result.putLong(getIssueDate());
+ result.putInt(getMasterKeyId());
+ result.putInt(getSequenceNumber());
+
+ result.putLong(getMaxDate());
+
+ result.putInt(getOwner().toString().length());
Review comment:
NIT: The Text class is a UTF-8 bytes + length wrapper class. You can use
getLength()/getBytes() without toString() conversion. Same apply to owner,
realuser and renewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
