adoroszlai commented on a change in pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454781348
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java
##########
@@ -88,21 +88,20 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
DeleteKeyRequest deleteKeyRequest = getOmRequest().getDeleteKeyRequest();
- OzoneManagerProtocolProtos.KeyArgs deleteKeyArgs =
+ OzoneManagerProtocolProtos.KeyArgs keyArgs =
deleteKeyRequest.getKeyArgs();
+ Map<String, String> auditMap = buildKeyArgsAuditMap(keyArgs);
- String volumeName = deleteKeyArgs.getVolumeName();
- String bucketName = deleteKeyArgs.getBucketName();
- String keyName = deleteKeyArgs.getKeyName();
+ String volumeName = keyArgs.getVolumeName();
Review comment:
> We can skip getting from original Args, as anyway final Volume/Bucket
we get is from resolvedBucket returned keyArgs.
Unfortunately not, because `volumeName` and `bucketName` are used later to
log result. If `resolveBucketLink` throws exception (eg. due to lack of
permission), then we exit from `try` earlier than getting `resolvedBucket` and
we need the original values from request.
https://github.com/apache/hadoop-ozone/blob/fbf04a33ecad2d23e8bd57ecceca4842a9cf5281/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java#L173-L183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
