sodonnel commented on pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#issuecomment-660110616
> > These changes with the striped lock LGTM, +1. > > One question - have you been able to test this change on your DNs with a large number of containers, and did it give a good improvement? > > Thanks @sodonnel . > Yes, I have tested it on a datanode with 20K+ containers, it costs about 30m to finish the ContainerSet build. Before the patch, time spending is about 10 times longer. If we ignore the lock during ContainerSet build, it costs about 15m. This seems like a good improvement for a relatively simply change. I think removing the lock completely is risky and may cause some other problems, either now or later. @bharatviswa504 @adoroszlai - have you guys any further comments or concerns with the latest patch? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
