bharatviswa504 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456668701
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java
##########
@@ -327,7 +344,164 @@ private OMRequest createKeyRequest(boolean
isMultipartKey, int partNumber) {
.setCmdType(OzoneManagerProtocolProtos.Type.CreateKey)
.setClientId(UUID.randomUUID().toString())
.setCreateKeyRequest(createKeyRequest).build();
+ }
+
+ @Test
+ public void testKeyCreateWithFileSystemPathsEnabled() throws Exception {
+
+ OzoneConfiguration configuration = new OzoneConfiguration();
+ configuration.setBoolean(OZONE_OM_ENABLE_FILESYSTEM_PATHS, true);
+ when(ozoneManager.getConfiguration()).thenReturn(configuration);
+ when(ozoneManager.getEnableFileSystemPaths()).thenReturn(true);
+
+ // Add volume and bucket entries to DB.
+ addVolumeAndBucketToDB(volumeName, bucketName,
+ omMetadataManager);
+
+
+ keyName = "dir1/dir2/dir3/file1";
+ createAndCheck(keyName);
+
+ // Key with leading '/'.
+ String keyName = "/a/b/c/file1";
+ createAndCheck(keyName);
+
+ // Commit openKey entry.
+ TestOMRequestUtils.addKeyToTable(false, volumeName, bucketName,
+ keyName.substring(1), 0L, RATIS, THREE, omMetadataManager);
+
+ // Now create another file in same dir path.
+ keyName = "/a/b/c/file2";
+ createAndCheck(keyName);
+
+ // Create key with multiple /'s
+ // converted to a/b/c/file5
+ keyName = "///a/b///c///file5";
+ createAndCheck(keyName);
+
+ // converted to a/b/c/.../file3
+ keyName = "///a/b///c//.../file3";
+ createAndCheck(keyName);
+
+ // converted to r1/r2
+ keyName = "././r1/r2/";
+ createAndCheck(keyName);
+
+ // converted to ..d1/d2/d3
+ keyName = "..d1/d2/d3/";
+ createAndCheck(keyName);
+
+ // Create a file, where a file already exists in the path.
+ // Now try with a file exists in path. Should fail.
+ keyName = "/a/b/c/file1/file3";
+ checkNotAFile(keyName);
+
+ // Empty keyName.
+ keyName = "";
+ checkNotAValidPath(keyName);
+
+ // Key name ends with /
+ keyName = "/a/./";
+ checkNotAValidPath(keyName);
+
+ keyName = "/////";
+ checkNotAValidPath(keyName);
+
+ keyName = "../../b/c";
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
