bharatviswa504 commented on pull request #1219: URL: https://github.com/apache/hadoop-ozone/pull/1219#issuecomment-661927733
> `proto.lock` file represents and older state of the protobuf files. When build is executed the plugin compares the current `*.proto` files and the `proto.lock` files. > > If we would like to be backward compatible with the previous release (in our case, it's 0.5.0) the `proto.lock` file should represent the `0.5.0` state. Therefore we shouldn't update it. > > After the 0.6.0 release we can update all the `proto.lock` files (once!), which means during the build the master state will be compared with the 0.6.0. > > As a thumb rule, `proto.lock` file should generated from the old proto which supposed to be backward compatible with the current proto files. Thank You @elek for your reply. I understood the process now. I agree with you, that before every release these proto.lock files should be updated at once. I will close this PR, but it creates a problem of proto.lock files getting updated during the build. I think this needs to be solved, as this causes problem these files are also showing up during PR commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
