nandakumar131 commented on a change in pull request #1145:
URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r458878853
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java
##########
@@ -60,6 +64,7 @@
/**
*
*/
+ //Can we move this lock to ContainerStateManager?
Review comment:
I would also like to move the lock to ContainerStateManager and not have
any lock in ContainerMangerImpl. I'm still thinking of corner cases where this
might cause issues.
State change calls to ContainerStateManager are made via Ratis, so we should
not check some state in ContainerMangerImpl and make a Ratis call to change the
state without holding any lock.
I will remove the lock in followup jira after making sure that we are not
missing any corner cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
