adoroszlai commented on a change in pull request #1232:
URL: https://github.com/apache/hadoop-ozone/pull/1232#discussion_r460776722
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/TestContainerReplication.java
##########
@@ -150,6 +154,8 @@ public void testContainerReplication() throws Exception {
-> destinationDatanodeDatanodeStateMachine.getSupervisor()
.getReplicationRequestCount() > 0, 1000, 20_000);
+ Assert.assertEquals(1, destinationDatanodeDatanodeStateMachine.
+ getSupervisor().getReplicationSuccessCount());
Review comment:
Is there any guarantee that if we have a request (ie. requestCount > 0),
then it is also successfully completed? I wouldn't think so.
I think we should wait for success:
```suggestion
.getReplicationSuccessCount() > 0, 1000, 20_000);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
