bharatviswa504 commented on a change in pull request #1270:
URL: https://github.com/apache/hadoop-ozone/pull/1270#discussion_r461950799
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3525,9 +3526,10 @@ private void addS3GVolumeToDB() throws IOException {
String dbVolumeKey = metadataManager.getVolumeKey(s3VolumeName);
if (!s3VolumeName.equals(OzoneConfigKeys.OZONE_S3_VOLUME_NAME_DEFAULT)) {
- LOG.warn("Make sure that all S3Gateway use same volume name." +
- " Otherwise user need to manually create/configure Volume " +
- "configured by S3Gateway");
+ LOG.warn(OZONE_S3_VOLUME_NAME + "configurations is deprecated. If " +
Review comment:
One of the reasons for this configuration is to use different volumeName
across different S3G's. So if someone is Using the configuration with that
intention, the logline was to say If different S3G's use different volumes,
make sure user creates those volumes before performing those operations.
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3525,9 +3526,10 @@ private void addS3GVolumeToDB() throws IOException {
String dbVolumeKey = metadataManager.getVolumeKey(s3VolumeName);
if (!s3VolumeName.equals(OzoneConfigKeys.OZONE_S3_VOLUME_NAME_DEFAULT)) {
- LOG.warn("Make sure that all S3Gateway use same volume name." +
- " Otherwise user need to manually create/configure Volume " +
- "configured by S3Gateway");
+ LOG.warn(OZONE_S3_VOLUME_NAME + "configurations is deprecated. If " +
Review comment:
One of the reasons for this configuration is to use different volumeName
across different S3G's. So if someone is Using the configuration with that
intention, the logline was to say If different S3G's use different volumes,
make sure user creates those volumes before performing those operations. (So,
no mention of the bucket in the log)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
