avijayanhwx commented on pull request #1255: URL: https://github.com/apache/hadoop-ozone/pull/1255#issuecomment-666542216
> I am still not sure about this one (but as I wrote I am not familiar). In case of a new snapshot: why don't we drop the previous one and start to use a new one? Why do we need a new db with new timestamp? To have a backup? Or to use the old version for some reason? @elek We actually do delete the old Recon container Key DB entirely after creating a new one from new OM snapshot. We rely on File.delete() rather than RocksDB delete since it is easier & faster. The only reason we 'tag' the name of the DB with the timestamp is to help with troubleshooting Recon - OM sync problems. Also, it is easier to create new DB with new timestamp, and then delete old DB which has old timestamp in its name. Based on the DB name and the logs, we know when and why the DB was created. In the future, when Recon becomes mature, we can remove the timestamp in the DB. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
