elek commented on pull request #1270:
URL: https://github.com/apache/hadoop-ozone/pull/1270#issuecomment-667478035


   > As the bucket link feature is available now.
   
   As I wrote in my previous comment, bucket link is not a replacement of this 
configuration. This configuration can expose an other volume and **all** 
buckets.
   
   With bucket links you should updated your links in case of the creation of 
any new bucket.
   
   > Get it. So not really deprecating it as the title says? @bharatviswa504
   
   It is deprecating but not removing:
   
   ```
       if (!volumeName.equals(OZONE_S3_VOLUME_NAME_DEFAULT)) {
         LOG.warn(OZONE_S3_VOLUME_NAME + " is deprecated. Consider using bucket 
" +
             "link command to access volume/buckets created via ozone shell " +
             "through S3Gateway and also to access buckets created by S3Gateway 
" +
             "version less than or equal to 0.5.0");
       }
   ```
   
   Which means that a warning will be printed out without alternatives (linking 
new bucket every day is not the same). As this feature is used by our early 
adopters (who started to use s3g with the old scheme) I think it's important to 
keep this functionality as is, without warning.
   
   As I wrote, I can accept the consensus proposal from @arp7: Let's remove it 
from the s3g doc page but keep the same code. (Later we can create a separated 
page about powerful but risky configuration, and it can be added back to 
there...) 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to