adoroszlai opened a new pull request #1285:
URL: https://github.com/apache/hadoop-ozone/pull/1285
## What changes were proposed in this pull request?
1. Move `--scm` parameter from `ozone admin` command to the subcommands that
actually need it. Currently all except `OMAdmin` do, but this is likely to
change by adding more `om` and other non-`scm` subcommands in the future. Now
it will be possible to convert `OzoneAdmin` to the pluggable model in
HDDS-4046, since it no longer depends on SCM functionality. This is made
easier by:
* extracting `--scm`-related logic to the new `ScmOption` mixin,
* extracting abstract parent class for `ScmClient`-based subcommands
(similar to `Handler` for `ozone shell` subcommands).
2. Upgrade picocli to 4.4.0. (Needed for `MIXEE`, but useful anyway.)
Note that moving the `--scm` parameter is backwards incompatible.
Previously the following command was valid:
```
ozone admin --scm scm:9860 pipeline list
```
and this one was not:
```
ozone admin pipeline list --scm scm:9860
```
but now it's the other way around. If necessary, we could provide backwards
compatibility, but I don't think it's worth the effort and extra code
complexity.
https://issues.apache.org/jira/browse/HDDS-4056
## How was this patch tested?
Existing acceptance tests cover some of the commands. Also added few new
test cases for `ozone admin pipeline`.
https://github.com/adoroszlai/hadoop-ozone/runs/933098595
https://github.com/adoroszlai/hadoop-ozone/runs/933098617
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
