adoroszlai commented on a change in pull request #1276:
URL: https://github.com/apache/hadoop-ozone/pull/1276#discussion_r464352920
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/OMAdmin.java
##########
@@ -50,7 +51,7 @@
subcommands = {
GetServiceRolesSubcommand.class
})
-public class OMAdmin extends GenericCli {
+public class OMAdmin extends GenericCli implements SubcommandWithParent {
Review comment:
Won't we need
```
@MetaInfServices(SubcommandWithParent.class)
```
too?
Currently `OMAdmin` is added to `OzoneAdmin` from the parent, so it's not a
problem. (#1285 will allow inverting subcommand registration for `OzoneAdmin`,
too.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
