bharatviswa504 commented on a change in pull request #1351:
URL: https://github.com/apache/hadoop-ozone/pull/1351#discussion_r476741653
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManager.java
##########
@@ -186,10 +186,11 @@ OmKeyLocationInfo allocateBlock(OmKeyArgs args, long
clientID,
* the key name and all its associated block IDs. A pending open key has
* prefix #open# in OM DB.
*
+ * @param count The maximum number of expired opne keys to return.
* @return a list of {@link BlockGroup} representing keys and blocks.
* @throws IOException
*/
- List<BlockGroup> getExpiredOpenKeys() throws IOException;
+ List<BlockGroup> getExpiredOpenKeys(int count) throws IOException;
Review comment:
Here, we can collect just expired KeyNames.
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManager.java
##########
@@ -186,10 +186,11 @@ OmKeyLocationInfo allocateBlock(OmKeyArgs args, long
clientID,
* the key name and all its associated block IDs. A pending open key has
* prefix #open# in OM DB.
*
+ * @param count The maximum number of expired opne keys to return.
* @return a list of {@link BlockGroup} representing keys and blocks.
* @throws IOException
*/
- List<BlockGroup> getExpiredOpenKeys() throws IOException;
+ List<BlockGroup> getExpiredOpenKeys(int count) throws IOException;
Review comment:
And also I think we might need last expired key also, as in next
iteration we need to start from that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
