linyiqun edited a comment on pull request #1208: URL: https://github.com/apache/hadoop-ozone/pull/1208#issuecomment-680961442
The POC patch looks great, we can flexibly adjust the replica number/ storage type for the storage. This is very similar to the HDFS storage policy design, some high level review comments from me: 1. Will we have the chance to switch storage class from its OpenStateConfiguration to its ClosedStateConfiguration? Will we support dynamically switch the storage class? I didn't see this switch logic in current patch. 2. ClosedStateConfiguration is only applied in closed state container, right? If yes, we should have the automatic behavior (e.g. background thread to do this) to convert container storage to ClosedStateConfiguration setting from its OpenStateConfiguration state. 3. It will be an improvement to support storage class on volume, bucket level in the future. Then key object can inherit storage class from them and user doesn't need to pass expected storage class every time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
