elek commented on a change in pull request #1352:
URL: https://github.com/apache/hadoop-ozone/pull/1352#discussion_r478391849
##########
File path: hadoop-ozone/dist/src/main/compose/ozone-om-ha/docker-config
##########
@@ -14,8 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-CORE-SITE.XML_fs.o3fs.impl=org.apache.hadoop.fs.ozone.OzoneFileSystem
-CORE-SITE.XML_fs.defaultFS=o3fs://bucket1.volume1.omservice
+CORE-SITE.XML_fs.defaultFS=ofs://omservice
Review comment:
AFAIK these are just helper lines, not really the test of the file
system. META-INF/services are already tested as test.sh is modified to do both
o3fs/ofs tests.
I am fine to replace all the `defaultFS` just let's agree first what do we
need to test. Do we need different MR test with both kind of `defaultFs`?
Or is it enough to test o3fs/ofs low level functionality and MR can use just
one of them?
(And you see it's a different discussion, that's the reason why I suggested
to do it in a separated PR. But can be included if you think it's better.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
