ayushtkn commented on a change in pull request #1316:
URL: https://github.com/apache/hadoop-ozone/pull/1316#discussion_r478571715



##########
File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java
##########
@@ -154,21 +155,21 @@ public void 
testCreateFileShouldCheckExistenceOfDirWithSameName()
     } catch (FileAlreadyExistsException fae) {
       // ignore as its expected
     }
+
+    // Cleanup
+    fs.delete(new Path("/d1/"), true);

Review comment:
       Shouldn't the cleanup be in a `finally` block? post `mkdir` if the test 
fails the directory won't get cleaned up. Wouldn't that affect other tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to