timmylicheng commented on a change in pull request #1346:
URL: https://github.com/apache/hadoop-ozone/pull/1346#discussion_r481146665
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestScmAdminHA.java
##########
@@ -0,0 +1,66 @@
+package org.apache.hadoop.ozone.shell;
Review comment:
Apart from UT, we can have an acceptance test to test CLI.
You may find examples here: https://github.com/apache/hadoop-ozone/pull/375
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java
##########
@@ -230,4 +230,5 @@ Pipeline
createReplicationPipeline(HddsProtos.ReplicationType type,
*/
boolean getReplicationManagerStatus() throws IOException;
+ List<String> getScmRatisStatus() throws IOException;
Review comment:
Any way to merge it with GetSCMInfo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
