GlenGeng commented on a change in pull request #1342:
URL: https://github.com/apache/hadoop-ozone/pull/1342#discussion_r481833398
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java
##########
@@ -334,8 +347,12 @@ ContainerInfo getMatchingContainer(final long size, String
owner,
throw new UnsupportedOperationException("Not yet implemented!");
}
- public void removeContainer(final HddsProtos.ContainerID id) {
- containers.removeContainer(ContainerID.getFromProtobuf(id));
+ @Override
+ public void removeContainer(final HddsProtos.ContainerID id)
Review comment:
we can verify the state of memory and RocksDB in Unit Test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
