runzhiwang opened a new pull request #1379: URL: https://github.com/apache/hadoop-ozone/pull/1379
## What changes were proposed in this pull request? **What's the problem ?**  **What's the reason ?** we can not make sure `omKeyInfo.getCreationTime()` equals to ` omKeyInfo.getModificationTime()` 1. the creationTime was set at [TestOMRequestUtils.addKeyToTable](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMAllocateBlockRequest.java#L68) -> [OmKeyInfo#createOmKeyInfo](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestOMRequestUtils.java#L253) 2. the modificationTime was set in KeyArgs at [doPreExecute(createAllocateBlockRequest())](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMAllocateBlockRequest.java#L58) -> [OMRequest#preExecute](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java#L115). And the KeyArgs.modificationTime was set in OmKeyInfo at [omAllocateBlockRequest.validateAndUpdateCache](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMAllocateBlockRequest.java#L84) -> [openKeyInfo.setModificationTime](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java#L203). 3. Between [doPreExecute(createAllocateBlockRequest())](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMAllocateBlockRequest.java#L58) and [TestOMRequestUtils.addKeyToTable](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMAllocateBlockRequest.java#L68), there is time consuming code, so we can not make sure the millisecond time is different. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-4199 ## How was this patch tested? no need new test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
