errose28 commented on a change in pull request #1298:
URL: https://github.com/apache/hadoop-ozone/pull/1298#discussion_r485195881
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestContainerCache.java
##########
@@ -85,17 +86,17 @@ public void testContainerCacheEviction() throws Exception {
// Get 2 references out of the same db and verify the objects are same.
ReferenceCountedDB db1 = cache.getDB(1, "RocksDB",
- containerDir1.getPath(), conf);
+ containerDir1.getPath(), OzoneConsts.SCHEMA_LATEST, conf);
Review comment:
This could be done, but it may not be clear to the caller that the
latest schema version would be applied. Since there is no mention of it in the
method name, the caller may assume that the schema version would be
automatically determined based on some property of the DB. Aside from this
series of calls in one test, the method is only called once in the code, so I
think it is OK to leave it the way it is for clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
