lokeshj1703 commented on a change in pull request #1414:
URL: https://github.com/apache/hadoop-ozone/pull/1414#discussion_r486841264
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/BackgroundService.java
##########
@@ -62,11 +56,11 @@ public BackgroundService(String serviceName, long interval,
this.interval = interval;
this.unit = unit;
this.serviceName = serviceName;
- this.serviceTimeout = serviceTimeout;
+ this.serviceTimeoutInNanos = TimeDuration.valueOf(serviceTimeout, unit)
+ .toLong(TimeUnit.NANOSECONDS);
Review comment:
I think we are ok with long even for nanoseconds. long can support a
value of ~292 years denoted as nanoseconds.
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/BackgroundService.java
##########
@@ -62,11 +56,11 @@ public BackgroundService(String serviceName, long interval,
this.interval = interval;
this.unit = unit;
this.serviceName = serviceName;
- this.serviceTimeout = serviceTimeout;
+ this.serviceTimeoutInNanos = TimeDuration.valueOf(serviceTimeout, unit)
+ .toLong(TimeUnit.NANOSECONDS);
Review comment:
I think we are ok with long even for nanoseconds. long can support a
value of ~292 years denoted as nanoseconds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
