maobaolong commented on a change in pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#discussion_r490169874
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestOMRequestUtils.java
##########
@@ -283,7 +285,8 @@ public static void addVolumeToDB(String volumeName, String
ownerName,
OmVolumeArgs omVolumeArgs =
OmVolumeArgs.newBuilder().setCreationTime(Time.now())
.setVolume(volumeName).setAdminName(ownerName)
- .setOwnerName(ownerName).build();
+ .setOwnerName(ownerName).setQuotaInBytes(1024 * GB)
Review comment:
If you want to keep this `QuotaInBytes` and `QuotaInCounts ` big
enough, you can set it to Long.MAX_VALUE;
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -269,6 +269,68 @@ public void testVolumeSetOwner() throws IOException {
proxy.setVolumeOwner(volumeName, ownerName);
}
+ @Test
+ public void testSetBucketQuota() throws IOException {
+ String volumeName = UUID.randomUUID().toString();
+ String bucketName = UUID.randomUUID().toString();
+ store.createVolume(volumeName);
+ store.getVolume(volumeName).setQuota(OzoneQuota.parseQuota(
+ "10GB", 10000L));
+ store.getVolume(volumeName).createBucket(bucketName);
+ OzoneBucket bucket = store.getVolume(volumeName).getBucket(bucketName);
+
+ Assert.assertEquals(OzoneConsts.QUOTA_RESET, bucket.getQuotaInBytes());
+ Assert.assertEquals(OzoneConsts.QUOTA_RESET, bucket.getQuotaInCounts());
+ store.getVolume(volumeName).getBucket(bucketName).setQuota(
+ OzoneQuota.parseQuota("1GB", 1000L));
+ OzoneBucket ozoneBucket =
store.getVolume(volumeName).getBucket(bucketName);
+ Assert.assertEquals(1024 * 1024 * 1024,
+ ozoneBucket.getQuotaInBytes());
+ Assert.assertEquals(1000L, ozoneBucket.getQuotaInCounts());
+ }
+
+ @Test
+ public void testSetBucketQuotaIllegal() throws IOException {
+ String volumeName = UUID.randomUUID().toString();
+ String bucketName = UUID.randomUUID().toString();
+ store.createVolume(volumeName);
+ store.getVolume(volumeName).createBucket(bucketName);
+
+ try {
+ store.getVolume(volumeName).getBucket(bucketName).setQuota(
+ OzoneQuota.parseQuota("1GB", -100L));
+ } catch (IllegalArgumentException ex) {
+ GenericTestUtils.assertExceptionContains(
+ "Invalid values for quota", ex);
+ }
+ // The unit should be legal.
+ try {
+ store.getVolume(volumeName).getBucket(bucketName).setQuota(
+ OzoneQuota.parseQuota("1TEST", 100L));
+ } catch (IllegalArgumentException ex) {
+ GenericTestUtils.assertExceptionContains(
+ "Invalid values for quota", ex);
+ }
+
+ // The setting value cannot be greater than LONG.MAX_VALUE BYTES.
+ try {
+ store.getVolume(volumeName).getBucket(bucketName).setQuota(
+ OzoneQuota.parseQuota("9999999999999GB", 100L));
Review comment:
You can use "9223372036854775808" here, it stand for the Long.MAX_VALUE
+ 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
