linyiqun commented on pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#issuecomment-700598266
> @linyiqun I do agree that I think this could be handled more cleanly and
efficiently in the container report handler. However its probably not much of
an overhead for replication manager. I am happy for us to commit the change as
it is, and we can see how it performs in practice. Worst case we have to
refactor the change out of RM into the report handler. What do you think?
+1 for this, @sodonnel .
@ChenSammi , can you add a TODO comment while committing like below? That
will be helpful for us to revisit this in the future.
// TODO: container report handling the empty containers.
if (isContainerEmpty(container, replicas)) {
deleteContainerReplicas(container, replicas);
}
+1 from me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
