elek commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499453456
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java
##########
@@ -147,7 +145,8 @@ public void testPutKeyAndGetKeyThreeNodes()
ReplicationFactor.THREE, new HashMap<>());
KeyOutputStream groupOutputStream =
(KeyOutputStream) out.getOutputStream();
- XceiverClientManager manager = groupOutputStream.getXceiverClientManager();
+ XceiverClientManager manager =
+ (XceiverClientManager) groupOutputStream.getXceiverClientFactory();
Review comment:
Both can work, but I feel it more safe as it doesn't require changing
method signatures in `KeyOutputStream`. Even if `getXceiverClientFactory` is
marked as `@VisibleForTesting` I feel it safer to return only the interface.
Unit test can have cast, it's expected to have access to the internal
representations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
