rakeshadr commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502350594
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -227,6 +247,9 @@ protected OmMetadataManagerImpl() {
@Override
public Table<String, OmKeyInfo> getOpenKeyTable() {
+ if (enableFSPaths && OzoneManagerRatisUtils.isOmLayoutVersionV1()) {
Review comment:
Good catch @bharatviswa504. Please feel free to add if anything else
needed. Thanks again!
Based on our offline discussions, below is the expected behavior for diff
requests:
**V1 feature version** : Following ops shouldn't depend on enableFSPaths flag
1) FileCreate -----> Look into dirTable for parents. Then create entries in
openFileTable and on close add it to fileTable.
2) DirCreate -----> Create entries in dirTable
3) File/DirDelete -> Look into fileTable and dirTable for the keys.
4) File/DirRename-> Look into fileTable and dirTable for the keys.
**V1 feature version & enableFSPaths=true**
1) KeyCreate ---> Look into dirTable for parents. Create entries in
openFileTable and on close add it to fileTable.
2) KeyDelete ---> Look into fileTable and dirTable for the keys.
3) KeyRename -> supported only in ozone shell. It should look into fileTable
and dirTable for the keys.
**V1 feature version & enableFSPaths=false**
1) KeyCreate ---> Create entries in openKeyTable and on close add it to
keyTable.
2) KeyDelete ---> Look into keyTable for the keys.
3) KeyRename -> supported only in ozone shell. It should look into keyTable
for the keys.
In this PR, will handle only `FileCreate` request and not provided checks
for enableFSPaths in KeyCommit. Will do this changes in latest commit.
Later, I will raise subsequent jiras for handling KeyCreate/KeyCommit and
other ops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
