ChenSammi commented on a change in pull request #1458:
URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502231114
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -218,6 +219,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
// update usedBytes atomically.
omVolumeArgs.getUsedBytes().add(preAllocatedSpace);
omBucketInfo.getUsedBytes().add(preAllocatedSpace);
+ long vol = omVolumeArgs.getUsedBytes().sum();
+ long buk = omBucketInfo.getUsedBytes().sum();
Review comment:
Are these two used somewhere?
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -279,11 +279,12 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);
omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);
- // check volume quota
+ // check volume and bucket quota
long preAllocatedSpace = newLocationList.size()
* ozoneManager.getScmBlockSize()
* omKeyInfo.getFactor().getNumber();
checkVolumeQuotaInBytes(omVolumeArgs, preAllocatedSpace);
+ checkBucketQuotaInBytes(omBucketInfo, preAllocatedSpace);
Review comment:
Better check bucket quota before volume quota check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
