The p2 publisher *does* support metadata generation for pre-Eclipse 3.0 bundles. This was required so we could support old existing update sites from the 2.x or possibly even 1.0 era.The code is in:
org.eclipse.equinox.p2.publisher.eclipse.BundlesAction#convertPluginManifest. As for the different manifest formats, we just generate a BundleDescription from a manifest using: org.eclipse.osgi.service.resolver.StateObjectFactory#createBundleDescription. So if that API supports old manifest formats then it should be passed along to p2 without the publisher ever caring. John On Thu, Feb 23, 2012 at 8:35 AM, Thomas Watson <[email protected]> wrote: > > Please see the thread below. I don't remember having this discussion in > p2, but it seems perfectly reasonable that p2 would not understand the > temporary attributes we used in Eclipse 3.0 (i.e optional=true, > reexport=true). This also made me question if the p2 publisher understood > 2.x style plugins (that have no bundle manifest). I am pretty sure the > answer is no to both. Please confirm. > > Tom > > > ----- Forwarded by Thomas Watson/Austin/IBM on 02/23/2012 07:31 AM ----- > |------------> > | From: | > |------------> > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |David M Williams/Raleigh/IBM@IBMUS > | > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |------------> > | To: | > |------------> > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |Gunnar Wagenknecht <[email protected]>, > | > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |------------> > | Cc: | > |------------> > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |[email protected] > | > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |------------> > | Date: | > |------------> > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |02/22/2012 05:20 PM > | > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |------------> > | Subject: | > |------------> > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > |Re: [orbit-dev] [ORBIT-BUILD: orbit-I] orbit-I Build Failed > | > > > >--------------------------------------------------------------------------------------------------------------------------------------------------| > > > > > > > To be honest, I do not ever remember "optional=true" ... but found evidence > of it in bug 82855 > https://bugs.eclipse.org/bugs/show_bug.cgi?id=82855 > where some of the directive format/syntax was changed ... back in 3.1, in > 2005! > > It appeared for some cases they did want "warning" if version 2 was used > with old syntax, but I had a hard time > following all the different cases. So, you might read through that bug, and > see if it seems covered there, or > fell through the cracks. > > As far as p2 publisher supporting only version 2 ... I suspect that was > intentional (since p2 came along after that, and guess the logic would be > if someone was going to "republish" some old manifests to p2 metadata, they > should update their manifest?) but I didn't search that bugzilla component, > and might have been a case that fell through the cracks? > > (As a general rule, I lean towards opening bugs, even if might end up being > invalid or "working as designed"). > > Worse, the build is still failing ... I guess for some other reason now. > I'll be looking at it this evening. > > > > > > From: Gunnar Wagenknecht <[email protected]> > To: [email protected], > Cc: David M Williams/Raleigh/IBM@IBMUS > Date: 02/22/2012 02:25 PM > Subject: Re: [ORBIT-BUILD: orbit-I] orbit-I Build Failed > > > > Hi folks, > > Am 22.02.2012 14:26, schrieb orbitBuilder: > > [orbit-set1] [eclipse.buildScript] Some inter-plug-in dependencies have > not been satisfied. > > [orbit-set1] [eclipse.buildScript] Bundle > org.apache.hadoop.zookeeper.tests: > > [orbit-set1] [eclipse.buildScript] > Unsatisfied > import package > com.sun.management_0.0.0. > > Sorry for the faild builds. Turns out that this error was triggered by a > bundle using the wrong bundle manifest version. PDE correctly handles > this. Thus, no error was visible in Eclipse. However, it looks like p2 > only understands bundle manifests version 2. > > There are very subtile difference. One uses "optional=true" on optional > package imports but p2 only understands "resolution:=optional" (which is > uses in version 2 of the bundle manifest). I wonder if this qualifies > for a bug report or if support was dropped (never implemented?) > intentionally. > > -Gunnar > > > > _______________________________________________ > orbit-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/orbit-dev > > > > _______________________________________________ > p2-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/p2-dev >
_______________________________________________ p2-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/p2-dev
