Hi Krysztof, The change you mention in SimpleConfigurator were on my todo list. I will definitely look into your patch and provide feedback in the bug. Note that in the launcher modification that I have committed in the sharedinstall branch I already set the the property to trigger p2 to react the changes. Btw, because of the nature of the values found in the config.ini we will have to have changes in both the launcher and in simpleconfigurator, so I don't think it is necessary to have simpleconfigurator worry about the config.ini.
Pascal On 2012-12-28, at 12:41 PM, Krzysztof Daniel wrote: > On Tue, 2012-12-18 at 15:30 +0000, Pascal Rapicault wrote: >> I've pushed my changes to a branch named prapicau/sharedInstall-part1 in >> both the p2 and the equinox repo, respectively found at >> http://git.eclipse.org/c/equinox/rt.equinox.p2.git/log/?h=prapicau/sharedInstall-part1 >> and >> http://git.eclipse.org/c/equinox/rt.equinox.framework.git/log/?h=prapicau/sharedInstall-part1 > > Hey Pascal, > > I have looked at your changes - and I like them in general (I had pretty > similar patch in Fedora for quite some time). > > My comments: > > If you look at > org.eclipse.equinox.internal.simpleconfigurator.SimpleConfiguratorImpl.getConfigurationURL(), > you'll find that OSGi is capable of ignoring user configuration (which > will be rewritten later). This is the first place where such a > calculation is made, and I believe it should be the only decisive > place. If nothing has changed, we use user configuration. If shared > configuration is newer than user one - use the shared one. Unfortunately > current implementation is weak - so I have opened 397216: [Shared] > Better shared configuration change discovery [1]. We could also include > things like config.ini into calculations here. > > Once we know that we dropped user configuration, we set up a property, > upon which P2 must react only once - drop user profile. We should be OK > at this point. I have not opened bugs for this point yet. > > Then it is "only" the matter of discovering bundles that had been > dropped. > > [1] 397216: [Shared] Better shared configuration change discovery > https://bugs.eclipse.org/bugs/show_bug.cgi?id=397216 > > _______________________________________________ > p2-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/p2-dev _______________________________________________ p2-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/p2-dev
