found it
i have to say not directly obvious (and what then that feature thing does
of unpack not unpack i have no idea)
but adding: Eclipse-BundleShape: dir
to the manifest of the plugin works
On Mon, 11 Nov 2019 at 17:02, Johan Compagner <jcompag...@gmail.com> wrote:
> hmm can't seem to get any luck these days
> i have the plugin, the setJvm is working (the eclipse.ini is updated)
> but updated to:
> -vm
> plugins/com.servoy.jre.test.win32.x86_64_12.0.0.jar/jre/bin/j9vm/jvm.dll
>
> that has 2 problems, i kind of expect a full path... this is my p2.inf:
>
>
> org.eclipse.equinox.p2.touchpoint.eclipse.setJvm(jvm:${artifact.location}/jre/bin/j9vm/jvm.dll);
>
> I wonder what happens if i make the eclipse install dir readonly..
>
> But ofcourse the main problem is that it doesn't extract it..
> The feature.xml does say that:
>
> <plugin
> id="com.servoy.jre.test.win32.x86_64"
> os="win32"
> arch="x86_64"
> download-size="40539"
> install-size="116415"
> version="12.0.0"
> unpack="true"/>
>
> (i also tried without unpack="true" which is i think default value)
>
> On the plugin itself i think i can't say that.. is there another place?
>
> johan
>
>
>
> On Mon, 11 Nov 2019 at 15:56, Johan Compagner <jcompag...@gmail.com>
> wrote:
>
>> So making it plugins that unzip..?
>>
>> i can try this.. would also mean i think that i don't get that problem of
>> deletion because eclipse doesn't try to directly delete plugins (i think,
>> not sure about unzipped plugins)
>>
>>
>>
>> On Mon, 11 Nov 2019 at 15:31, Mickael Istria <mist...@redhat.com> wrote:
>>
>>> Hi Johan,
>>>
>>> It looks like using features (group/jar) makes things more complex here.
>>> It is indeed likely that all this was never successfully used by anyone
>>> so far ;)
>>> However, if the final goal is to ship a JRE as a p2 unit, what just
>>> using platform-specific bundles instead of platform-specific features? With
>>> bundles, you wouldn't face the group vs jar issue and might be more
>>> successful.
>>> HTH
>>> _______________________________________________
>>> p2-dev mailing list
>>> p2-dev@eclipse.org
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://www.eclipse.org/mailman/listinfo/p2-dev
>>
>>
_______________________________________________
p2-dev mailing list
p2-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://www.eclipse.org/mailman/listinfo/p2-dev
