3.1
Each node has a certificate [RFC5280] containing a Node-ID, which is
  globally unique

I'm wondering how you want to ensure global uniqueness.

Regards


neil.young schrieb:
Next:
Page 44: Explanation of the possible values of "type". "peer" has to be "node"

One question concerning serialization: 5.3.2.2

 struct {
          DestinationType         type;
          uint8                   length;
          DestinationData         destination_data;
        } Destination;

Because DestinationData may contain a type with variable length, the DestinationData struct by chance carries a length indicator implicitly (e.g. for resource or compressed id types). Is the additional length element of the Destination struct an error or really meant to be there? If latter case is true, it might not be sufficient to count for all the data following:

Given a resource ID of 0x010203 the message would appear like this on the wire:

0x02 - Destination type resource
0x04 - Length of the following
0x03 - Length of the resource id as defined by the ABNF notation of ressourceID
0x01 0x02 0x03 - Ressource ID

In case, the length of the ressource ID is 255 byte, it would have to look like this
0x02
0x00 - ! overflow
0xFF
0x01......

I propose to drop the "length" definition from the Destination struct or let this field be an uint16.

Regards



Neil.Young schrieb:
Nit-picky: Page 18, explanation for "Kind": The last line contains several typos.

More important: Inconsistency (?) concerning the number of node_ids per certificate. 3.1 is very specific concerning the number of node_ids per certificate - just one, if I understand that correctly. In contrary 10.3 seems to allow more than one node_id per certificate (pg. 118, "one or more Node-IDs"). I personally wouldn't know, how to deal with more than one node_id per node.

Regards
_______________________________________________
P2PSIP mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/p2psip
------------------------------------------------------------------------

_______________________________________________
P2PSIP mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/p2psip
_______________________________________________
P2PSIP mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/p2psip

Reply via email to