On Nov 22, 2010, at 11:32 AM, Marc Petit-Huguenin wrote:
> ]
> Because of this, it is probably a good idea to add in p2psip-base the
> possibility to know the source Node-ID and destination Node-ID of a message.
> One way to do that would have be to have the sender of a message add its own
> Node-ID in the via_list, and the Node-ID of the destination in the
> destination_list before sending a message (similar to what SIP is doing), but 
> I
> guess that it is too late for such a modification.

I don't think I understand your point about destination node-ids. They will
be in the destination list, no? I agree about source.


We would also need to add text about populating the routing table with
"accidental" adjacencies. I.e., if you connect to node 1234 and it gives you
a cert for 1234 and 5678 you need to automatically add that as a routing
adjacency.


> - - A.11. Looking at the examples in section 3.3, it seems that the via_list 
> is
> updated only when the message forwarded is a request but not for responses, 
> but
> I cannot find this anywhere in the text.  So are all messages processed the 
> same
> way when forwarded (and via updated on all types of messages) or specifically 
> on
> requests? (by testing the last bit of message_code).
> 
> - - A.12. Section 10.3 states that "[t]he SubjectAltName field in the 
> certificate
> contains the following values: One or more Node-IDs...", but nowhere it is 
> said
> how to request multiple Node-IDs.  Is it an URL parameter of the POST request?
> An attribute in the Certification Request object?
> 

Good question. This is an issue that's simply not addressed in the draft., but 
presumably
we'll need to do something like this, yeah. My taste would be for it to be a 
URL in the POSt.


> 
> Nits
> ====
> 
> - - Section 5.3, in the list "Security Block:"
> 
> s/""Message Contents"/"Message Contents"/
> 
> - - Section 5.3.2.1
> 
> s/destination_value/destination_data/
> 
> - - Section 5.3.4 "overlay + transaction_id + MessageContents + 
> SignerIdentity"
> 
> The "+" should probably be replaced with "||".
> 

Done.

-Ekr

> - -- 
> Marc Petit-Huguenin
> Personal email: [email protected]
> Professional email: [email protected]
> Blog: http://blog.marc.petit-huguenin.org
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> 
> iEYEARECAAYFAkzqxUgACgkQ9RoMZyVa61fLpQCglb3AQGXUnEmD6athMaIGFBAx
> vLkAn2r+Gy54Z/sJHMNv/j0i4Ic4y2ZZ
> =bP6t
> -----END PGP SIGNATURE-----
> _______________________________________________
> P2PSIP mailing list
> [email protected]
> https://www.ietf.org/mailman/listinfo/p2psip
> 

_______________________________________________
P2PSIP mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/p2psip

Reply via email to