On Mar 7, 2011, at 9:03 PM, Marc Petit-Huguenin wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> More...
> 
> A.45. Section 9
> 
> The hash function is never defined for the chord overlay.

Ouch - how embarrassing :-) Added a section 9.2. I think that all 
implementation are using the top 128 bits not the bottom but please do check I 
got the text the in section 9.2 right. 


> 
> A.46. Section 10.3 "application/pkix-cert
> 
> I think that a reference to RFC 2585 should be added here.
done

> 
> 
> Nits:
> - ----
> 


> - - Section 5.3.1.1 The definition of IpAddressPort is missing a "};" at the 
> end
> of the select.
fixed 


> 
> - - Section 5.3.4 The definition of SignerIdentityValue is missing a "};" at 
> the
> end of the select.
Changed to following - check this looks right to you

 struct {
    select (identity_type) {
      case cert_hash;
        HashAlgorithm      hash_alg;              // From TLS
        opaque             certificate_hash<0..2^8-1>;
      /* This structure may be extended with new types if necessary*/
    };
  } SignerIdentityValue;

> 
> - - Section 5.4.2.2
> 
> s/public struct/struct/
fixed

> 
> - - Section 5.5.1.1 The definition of IceCandidate is missing a ";" at the 
> end of
> the select.
fixed 

> 
> - -- 
> Marc Petit-Huguenin
> Personal email: [email protected]
> Professional email: [email protected]
> Blog: http://blog.marc.petit-huguenin.org
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> 
> iEYEARECAAYFAk11qpoACgkQ9RoMZyVa61fx3wCfZK1U1zOWlSA13OPXoVmhrhsb
> mZ4AnAz+0E7ny/MI7CRvtKSOJpXg2XD+
> =gBto
> -----END PGP SIGNATURE-----
> _______________________________________________
> P2PSIP mailing list
> [email protected]
> https://www.ietf.org/mailman/listinfo/p2psip

_______________________________________________
P2PSIP mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/p2psip

Reply via email to