On 02/28/2010 10:36 PM, Cristian Mammoli - Apra Sistemi wrote: > In 2008 I posted on the linux-ha ML a resource agent script for vmware > server 2 virtual machines. It has been slightly modified and shipped > with heartbeat and (now) pacemaker. > Actually the script is broken: > the script is named "vmware" while the "resource-agent name" is set to > "vmwarevm". They should match.
This was fixed upstream 2 months ago; both are now named "vmware": http://hg.linux-ha.org/agents/rev/4b1f781a51cf > Besides that, even if all the "OCF_" stuff is correctly declared the > script always reports: > "WARNING: Could not find out virtual machine name" > > That's because in the modified version the function "set_environment" is > not properly executed before actually starting and stopping resources. This was also fixed upstream, http://hg.linux-ha.org/agents/rev/ae1ebe1f151b. There are a few other upstream changes you may have missed. Could you please rebase your patch on current upstream and send a hg export patch? Or, alternatively, could you diff your new version against the one you orginally submitted, and submit that patch? That makes merging a whole lot easier for us. Thanks! Cheers, Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker