Hi Jiaju, I found some issues. So, I want to fix those issues. And, I want to replace this patch. Please wait to merge this patch.
Sincerely, Yuichi 2013/1/15 Yuichi SEINO <seino.clust...@gmail.com>: > Hi Jiaju, > > 2013/1/14 Jiaju Zhang <jjzh...@suse.de>: >> Hi Yuichi, >> >> Thanks for the patch! >> >> However, I need to say some coding style problem first;) I didn't say >> this before, so it seems a little bit messy and will confuse a lot of >> contributors and users, sorry for the inconvenience;) >> >> Now I'd like to say that booth is inclined to use the Linux kernel >> coding style. For the existing problems in the booth repository, I'm >> going to cleanup the code soon. For the newly submitted patches, I'd >> like them to obey the kernel coding style. >> >> So Yuichi, before I looked at this patch in more detail, could you use >> the checkpatch.pl (in kernel source tree) script to check the patch >> first?;) > > OK. > I pushed a commit after I used checkpatch.pl. in Linux 3.7.2 > > Sincerely, > Yuichi > >> >> Thank you very much! >> >> Regards, >> Jiaju >> >> On Sat, 2013-01-12 at 00:48 +0900, Yuichi SEINO wrote: >>> Hi Jiaju, >>> >>> I could fix this issue.I send the pull request. >>> https://github.com/jjzhang/booth/pull/47 >>> >>> Sincerely, >>> Yuichi >>> -- Yuichi SEINO METROSYSTEMS CORPORATION E-mail:seino.clust...@gmail.com _______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf Bugs: http://bugs.clusterlabs.org
