Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=554647 Fabian Affolter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Fabian Affolter <[email protected]> 2010-01-13 05:32:08 EST --- Just some comments after a quick look at your spec file. - The summary needs some love https://fedoraproject.org/wiki/Examples_of_good_package_summaries - Lines in the %description seems to be to long - Remove %pre, %post, and %postun they are useless - gcc is not needed https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 - All GUI applications need a .desktop file https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Please preserve the time stamps https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps - Isn't parallel building working? https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
