Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557169 Thomas Spura <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #7 from Thomas Spura <[email protected]> 2010-01-23 20:49:29 EST --- Review: Good: - name ok - libs correctly packed - no static libs - %files ok - permissions ok - BR ok - no *.la - %install ok - ldconfig ok - %clean there - desktop file ok - license ok Needswork: - %doc: INSTALL is not needed as doc (just for you as maintainer, not for enduser) - Please check, if the zero-length files are needed for runtime. If not delete them. - The svg icon works great with: install -p -m 0644 bitmaps/bicon.svg $RPM_BUILD_ROOT%{_datadir}/pixmaps/bristol.svg Then no gtk-update-icon-cache is needed. - You could query upstream to remove the excetuable bits, so %prep would look more pretty :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
