Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551724 --- Comment #5 from Christof Damian <[email protected]> 2010-01-30 13:40:22 EST --- (In reply to comment #3) > First/quick notes > > - Replace %define by %global (I have miss this on previous reviews...) > - use %{channel} in %postun > - use %{pear_datadir} instead of %{pear_phpdir}/data all done. I will replace the define while doing other updates on the other packages. > > All docs should be in /usr/share/doc/php-phpmd-PHP-PMD-0.2.1 > > Most of pear package use (what is generated by pear make-rpm-spec): > > after install: > mv $RPM_BUILD_ROOT%{pear_docdir}/* docdir > > and in %file > %doc %{pear_name}-%{version}/docdir/%{pear_name}/* That makes sense. (In reply to comment #4) > According to package.xml this requires dom extension > According to pci this requires libxml and SimpleXML > > So, replace > Requires: php-common >= 5.2.0 > With > Requires: php-xml >= 5.2.0 I added the php-xml. I prefer to have the php-common requirement with the php version number and the separate requirement for php-xml, because it makes the spec file more readable. Is that ok too? Or is there a guideline to reduce the requires to a minimum? I also upgraded to the new upstream bugfix release: Spec URL: http://rpms.damian.net/SPECS/php-phpmd-PHP-PMD.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpmd-PHP-PMD-0.2.2-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
