Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521716 --- Comment #3 from Ruben Kerkhof <[email protected]> 2010-01-31 15:01:04 EST --- > - %install: why don't you need the cmdtools? I've added them. > - %check section would be great, then you'd found out the next issue: > - missing Requires: pyutil which is not yet in fedora... I've added the %check section, and packaged up pyutil (#560457) > - Be a bit more explicit in %files: > %{python_sitearch}/%{name} and %{python_sitearch}/%{name}*.egg-info would be > better. Ok, fixed. > - Query upstream to add license headers. Why, the license is included > - Are the patches upstream There's one patch left which removes darcsver, which isn't needed. Upstream uses it quite a lot. New SPEC: http://ruben.fedorapeople.org/python-zfec.spec New SRPM: http://ruben.fedorapeople.org/python-zfec-1.4.6-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
