Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562993 Mamoru Tasaka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Mamoru Tasaka <[email protected]> 2010-02-12 13:26:58 EST --- Some notes: * Macros - Defined %ruby_sitelib is used nowhere - Please use defined %geminstdir also in %files * ruby(abi) dependency - "Requires: ruby(abi) = 1.8" dependency is missing https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * License -------------------------------------------------------- Overall: MIT GPLv2 or Ruby ./lib/yard/parser/c_parser.rb -------------------------------------------------------- - License tag should be "MIT and (GPLv2 or Ruby)". * SourceURL - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem * Documents - "ChangeLog", "LICENSE", "README.md" under %geminstdir should properly be marked as %doc (and we usually also mark Rakefile as %doc) - Also benckmarks/ docs/ spec/ templates/ directories can be marked as %doc (and please consider to split these files/directories into -doc subpackage) * %check - As this package contains spec/ directory, please add %check section and execute some test program (like $ rake spec) there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
