Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565811

Mamoru Tasaka <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #5 from Mamoru Tasaka <[email protected]> 2010-02-16 
10:44:16 EST ---
Quick notes:

- README.rdoc says that license is under MIT
- build.log says there is some duplicate %files entry,
  please fix this (this is a MUST item)
  https://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- Now we prefer to use %global over %define
 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
- Please use %geminstdir macro in %files list because you have
  explicitly defined this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to