Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469931 Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flag|needinfo? |needinfo? --- Comment #22 from Terje Røsten <[email protected]> 2010-02-16 12:06:43 EST --- Andy, are you the upstream maintainer too? The rpm might do the job a standalone download, but there are a lot issues to be fixed before this can be accepted in Fedora. For starters clean up the scripts, they are a mess. If possible remove them entirely. Then, please clearly explain what is used to query already IMPI enabled device, and what parts which turn the host machine into a IMPI enabled device. Then split the package accordingly. Remove all %define, they look very strange and with no purpose. Many on the commands have to generic names; sensor, alarms, hwreset etc and will never be accepted. Consider to fold everything in one command with sub commands $ ipmiutil sensor $ impiutil hwreset etc There are more (e.g. optflags, changelog), however fix these and I will continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
