Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518647

Matthias Runge <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #8 from Matthias Runge <[email protected]> 2010-02-17 
04:53:24 EST ---
Sadly, I'm unable to give you an official review. If you like, I'd give you
some inofficial comments

rpmlint django-robots-0.6.1-3.fc12.src.rpm django-robots.spec 
django-robots.src: W: spelling-error Summary(en_US) txt -> text, ext, tit
django-robots.src: W: spelling-error %description -l en_US txt -> text, ext,
tit
django-robots.src: W: spelling-error %description -l en_US Sitemap -> Site map,
Site-map, Sideman
django-robots.src: W: spelling-error %description -l en_US contrib -> cont rib,
cont-rib, contribute
django-robots.src: W: invalid-url Source0:
http://bitbucket.org/jezdez/%{Name}/get/django-robots-0.6.1.tar.gz HTTP Error
400: Bad Request
django-robots.spec: W: invalid-url Source0:
http://bitbucket.org/jezdez/%{Name}/get/django-robots-0.6.1.tar.gz HTTP Error
400: Bad Request
1 packages and 1 specfiles checked; 0 errors, 6 warnings.

* %define version vs. Version: ?

* %{Name} should be %{name} (lower case) in Source0.
* BuildRequires should require python-setuptools, not python-setuptools-devel
* Build produces warning:
warning: File listed twice:
/usr/lib/python2.6/site-packages/robots/locale/de/LC_MESSAGES/django.mo
warning: File listed twice:
/usr/lib/python2.6/site-packages/robots/locale/fr/LC_MESSAGES/django.mo


* Package Name is ok, spec-file named according to package name.

* License seems to be a kind of propriary license. Listed in SPEC is BSD,
LICENSE.txt 

* LICENSE etc goes to %doc (ok)

* SPEC file is legible and in plain american english (good)

* find_lang is unused in favor of own script. (ok / not ok ?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to