Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565902

--- Comment #9 from Terje Røsten <[email protected]> 2010-02-17 17:47:08 
EST ---
>>  - change all %__foo macros to %{__foo}
>I don't see a reason for this, only if the macro would support options.

Never seen %__foo style used before, that's all.

>>  - tags are in strange order
>Is there a rule for the order?

Just the "most important stuff first" rule I would say.

>>  - is source1 of any use?

>Sure, you can verify that the source archive hasn't been modified.
>gpg --verify csync-0.44.0.tar.gz.asc
>It is like a md5sum but cryptographic secured.
>They are included in other SRPMS of Fedora too. See libssh for example.

Ok, .asc is not large anyway.

Package is in pretty good shape now, thanks so far Andreas.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to